Update for newer Elixir versions #39
Conversation
| - elixir: '1.7' | ||
| otp_release: '19.3' | ||
| - elixir: '1.7' | ||
| otp_release: '20.3' | ||
| - elixir: '1.7' | ||
| otp_release: '21.0' | ||
| - elixir: '1.8' | ||
| otp_release: '20.3' | ||
| - elixir: '1.8' | ||
| otp_release: '21.0' | ||
| - elixir: '1.8' |
There was a problem hiding this comment.
do you want to keep these old versions in the matrix? how far back?
There was a problem hiding this comment.
Also, let me know if you'd prefer to switch to GitHub Actions instead.
There was a problem hiding this comment.
Hey nathany! thanks for starting this! Yes please I would love to move us to Github Actions!
There was a problem hiding this comment.
And happy to drop old versions. Happy to stay with the Elixir 1.15+ if that's possible
| {:cowboy, "~> 2.8.0"}, | ||
| {:cowboy, "~> 2.12.0"}, | ||
| {:exjsx, "~> 3.0 or ~> 4.0"}, | ||
| {:con_cache, "~> 0.14.0"}, | ||
| {:con_cache, "~> 1.1.0"}, | ||
| {:earmark, "~> 1.0", only: :dev}, | ||
| {:ex_doc, "~> 0.18", only: :dev}, | ||
| {:meck, "~> 0.8.13", only: :test} | ||
| {:meck, "~> 0.9.2", only: :test} |
There was a problem hiding this comment.
any reason to support older versions?
a lot of the deprecation warnings we've seen are coming from the old version of cowboy
There was a problem hiding this comment.
No reason to support old versions. We can bump everything!
|
This fixes the warnings and all the tests pass in Elixir 1.16, but it isn't enough to fix the test failures reported by Tesla. |
|
@nathany-copia I have a fix for the SSL issue once we get this merged 👍 Let me know if you want to get the GitHub Actions setup done. Cheers! |
closes #38
Compiles without warnings and all tests are passing in Elixir 1.16.
We'll have to see what Travis CI reports for older versions, and may need to adjust to support multiple versions at once. How many versions back would you like to support?